[rocBLAS] scalar vector API option#7507
Draft
TorreZuk wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (69.24%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7507 +/- ##
===========================================
- Coverage 66.24% 66.24% -0.00%
===========================================
Files 1605 1605
Lines 267473 267553 +80
Branches 37300 37310 +10
===========================================
+ Hits 177183 177227 +44
- Misses 75455 75478 +23
- Partials 14835 14848 +13
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
The _stride form instead of inc with rocblas_stride as types may be the way to go to keep it future proof and consistent with current internal APIs |
TorreZuk
added
ci:extended
noTensile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new API for strided alpha and beta parameters in batched and strided batched GEMV, along with new tests and supporting infrastructure to validate this feature. The changes touch on argument handling, test YAMLs, utility functions, and the GEMV test implementations to enable and verify per-batch striding for these scalar parameters.
Support for strided alpha/beta in GEMV tests:
alpha_beta_stridefield to theArgumentsstruct, YAML config, and test infrastructure to enable per-batch striding for alpha and beta parameters.Test infrastructure and utility improvements:
set_get_alpha_beta_stride_gtest.cppand.yaml) to verify the correct setting and getting of batch alpha/beta strides, and integrated them into the test suite and auxiliary test YAMLs.rocblas_local_handleutility to set/reset batch alpha/beta strides based on the new argument.rocblas_init_vector_alternating_zeroto initialize vectors with alternating zero and a given value, used for alpha/beta initialization in the tests.Documentation:
Test coverage:
These changes collectively enable and validate the use of per-batch striding for alpha and beta scalars in GEMV batched operations, improving the flexibility and correctness of the test suite.
ROCM-24002